[PATCH] Fix intermittent crash in NTVFS server.
Andrew Bartlett
abartlet at samba.org
Sat Apr 1 18:23:46 UTC 2017
On Sat, 2017-04-01 at 14:15 -0400, Jim Brown via samba-technical wrote:
> You should add "/* NOT REACHED */" after model_ops->terminate() to
> show
> control never returns from this call.
>
> Do any other callers of model_ops->terminate() assume control
> returns?
Thanks for taking the time to look over our patches!
In this case it is a little more tricky than that, it can return if the
server is in single process mode (which tries to be a giant state
machine).
/* called when a task goes down */
static void single_terminate(struct tevent_context *ev, struct
loadparm_context *lp_ctx, const char *reason)
{
DEBUG(3,("single_terminate: reason[%s]\n",reason));
}
Thanks,
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list