[PATCH] Fix intermittent crash in NTVFS server.

Jim Brown jim.brown at rsmas.miami.edu
Sat Apr 1 18:15:24 UTC 2017

You should add "/* NOT REACHED */" after model_ops->terminate() to show 
control never returns from this call.

Do any other callers of model_ops->terminate() assume control returns?

On 4/1/17 13:27, Jeremy Allison via samba-technical wrote:
> This one was fun to find and track down (and
> by that I mean "not fun at all" :-).
> I discovered it because of a patch series
> I'm preparing that reduces use of the talloc_autofree
> context (which I'll post a little later) that made
> the flaw fully reproducible.
> The commit message describes the bug pretty
> thoroughly. If you've ever seen an intermittent crash with
> ntvfs trying to send out dgm messages on shutdown,
> this is the one :-).
> Please review and push !
> Jeremy.

More information about the samba-technical mailing list