[PATCH] Fix nss_wins
Andreas Schneider
asn at samba.org
Tue Sep 20 11:29:06 UTC 2016
On Monday, 19 September 2016 19:52:53 CEST Jim McDonough wrote:
> On 09/19/2016 06:55 PM, Jim McDonough wrote:
> >>>> Please review and push if OK.
> >>>
> >>> Why are you giving two errno pointers? from netdb.h:
> >>> extern int gethostbyname_r (const char *__restrict __name,
> >>>
> >>> struct hostent *__restrict __result_buf,
> >>> char *__restrict __buf, size_t __buflen,
> >>> struct hostent **__restrict __result,
> >>> int *__restrict __h_errnop);
> >
> > But, your prototype does line up with what the files and dns nss modules
> > do. Sigh. I *&$ hate nsswitch...
>
> So yes, LGTM too. pushed. Sorry for the noise.
We should set h_errnop too.
Please review :)
Cheers,
-- andreas
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
www.samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-nsswitch-Also-set-h_errnop-for-nss_wins-functions.patch
Type: text/x-patch
Size: 2583 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160920/f3d1beab/0001-nsswitch-Also-set-h_errnop-for-nss_wins-functions.bin>
More information about the samba-technical
mailing list