[PATCH] Fix nss_wins
Jim McDonough
jmcd at samba.org
Tue Sep 20 14:34:24 UTC 2016
On 09/20/2016 07:29 AM, Andreas Schneider wrote:
> On Monday, 19 September 2016 19:52:53 CEST Jim McDonough wrote:
>> On 09/19/2016 06:55 PM, Jim McDonough wrote:
>>>>>> Please review and push if OK.
>>>>>
>>>>> Why are you giving two errno pointers? from netdb.h:
>>>>> extern int gethostbyname_r (const char *__restrict __name,
>>>>>
>>>>> struct hostent *__restrict __result_buf,
>>>>> char *__restrict __buf, size_t __buflen,
>>>>> struct hostent **__restrict __result,
>>>>> int *__restrict __h_errnop);
>>>
>>> But, your prototype does line up with what the files and dns nss modules
>>> do. Sigh. I *&$ hate nsswitch...
>>
>> So yes, LGTM too. pushed. Sorry for the noise.
>
> We should set h_errnop too.
Yep, looks good. And it does fix the segfaults...
Pushed
More information about the samba-technical
mailing list