[PATCH 3/6] Samba-VirusFilter: build and memcache changes.

[Trever L. Adams]

On 10/19/2016 01:25 PM, Jeremy Allison wrote:
> On Wed, Oct 19, 2016 at 01:21:28PM -0600, Trever L. Adams wrote:
>> On 10/19/2016 07:02 AM, Stefan Metzmacher wrote:
>>> Hi Trever,
>>>
>>>> From b6f96bf00c13058c043861370632eb07da0f6d1d Mon Sep 17 00:00:00 2001
>>>> From: "Trever L. Adams" <trever.adams at gmail.com>
>>>> Date: Tue, 18 Oct 2016 13:37:19 -0600
>>>> Subject: [PATCH 3/6] Samba-VirusFilter: build and memcache changes.
>>>>
>>>> Signed-off-by: Trever L. Adams <trever.adams at gmail.com>
>>>> Signed-off-by: SATOH Fumiyasu <fumiyas at osstech.co.jp>
>>>> ---
>>>>  buildtools/wafsamba/stale_files.py |  2 +-
>>>>  docs-xml/wscript_build             |  9 ++++++---
>>>>  lib/util/memcache.c                |  1 +
>>>>  lib/util/memcache.h                |  3 ++-
>>>>  source3/modules/wscript_build      | 29 +++++++++++++++++++++++++++++
>>>>  source3/wscript                    |  8 +++++++-
>>>>  6 files changed, 46 insertions(+), 6 deletions(-)
>>> Please put the memcache changes to their own commit.
>>>
>>> Please also make sure each commit compiles, that
>>> means that the build changes patch needs to be at the end of the patchset.
>>>
>>> Thanks!
>>> metze
>>>
>> Thank you. I should have done that to begin with.
>>
>>> Please use values from the main config.h or from dynconfig.h
>>> e.g. via get_dyn_STATEDIR(), lp_state_directory() or state_path(),
>>> while state_path() should be the preferred option for vfs modules.
>>> Using lp_parm_const_string(SNUM(handle->conn)...) to overwrite a value
>>> per share may also make sense for an vfs module.
>> Thank you. That solved many problems. The DEFAULT defines can all be
>> overridden by configuration. Thank you for having me check that.
>>
>> Alexander Bokovoy had some requested changes as well. 4 out of 6 patches
>> have changed and there is a 7th. Would it be best to resend the entire
>> series?
> Yes - the way we normally do this for a large patchset (multiple
> iterations) is to mark each email set with a version #.
>
> E.g.: [PATCH] Samba-VirusFilter: build and memcache changes. - version #3
>
Alright, I am awaiting feedback on one of the changes. As soon as I have
that, I will resend the entire series.

Thank you all for helping SATOH Fumiyasu and myself get this integrated.

Trever


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161019/4be77afc/signature.sig>