[PATCH 3/6] Samba-VirusFilter: build and memcache changes.

[Stefan Metzmacher]

Hi Trever,

Am 18.10.2016 um 21:48 schrieb Trever L. Adams:
> diff --git a/buildtools/wafsamba/stale_files.py b/buildtools/wafsamba/stale_files.py
> index 2dd08e1..0afbfe4 100644
> --- a/buildtools/wafsamba/stale_files.py
> +++ b/buildtools/wafsamba/stale_files.py
> @@ -88,7 +88,7 @@ def replace_refill_task_list(self):
>                  link = os.readlink(p)
>                  if link[0:bin_base_len] == bin_base:
>                      p = link
> -            if f in ['config.h']:
> +            if f in ['config.h', 'vfs_virusfilter_config.h']:
>                  continue
>              (froot, fext) = os.path.splitext(f)
>              if fext not in [ '.c', '.h', '.so', '.o' ]:
>
> ...
>
>      conf.SAMBA_CONFIG_H('include/config.h')
> +    old_defines = conf.env['defines']
> +    conf.env['defines'] = {}
> +    conf.define('VARDIR', conf.env['STATEDIR'])
> +    conf.write_config_header('include/vfs_virusfilter_config.h')
> +    conf.env['defines'] = old_defines

There's no need for a vfs_virusfilter_config.h file.

Please use values from the main config.h or from dynconfig.h
e.g. via get_dyn_STATEDIR(), lp_state_directory() or state_path(),
while state_path() should be the preferred option for vfs modules.
Using lp_parm_const_string(SNUM(handle->conn)...) to overwrite a value
per share may also make sense for an vfs module.

If you really need to pass a value from the configure to the build step
specify special values as cflags="-DSOME=VALUE" in the SAMBA3_MODULE()
definition if really required.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161019/a54064a4/signature.sig>