[PATCH] mostly clang warnings

[Jeremy Allison]

On Tue, Oct 18, 2016 at 04:25:26PM +0200, Volker Lendecke wrote:
> 
> From 9b759b98d129f868616402714472eb84cdbdc535 Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Thu, 13 Oct 2016 16:20:12 +0200
> Subject: [PATCH 8/8] libsmb: "cli" is not needed in
>  cli_smb2_shadow_copy_data_fnum_state
> 
> We only have a single subreq
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> ---
>  source3/libsmb/cli_smb2_fnum.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
> index cf00f60..ad57cf7 100644
> --- a/source3/libsmb/cli_smb2_fnum.c
> +++ b/source3/libsmb/cli_smb2_fnum.c
> @@ -3303,7 +3303,6 @@ NTSTATUS cli_smb2_splice_recv(struct tevent_req *req, off_t *written)
>  ***************************************************************/
>  
>  struct cli_smb2_shadow_copy_data_fnum_state {
> -	struct cli_state *cli;
>  	uint16_t fnum;
>  	struct smb2_hnd *ph;
>  	DATA_BLOB out_input_buffer;
> @@ -3334,7 +3333,6 @@ static struct tevent_req *cli_smb2_shadow_copy_data_fnum_send(
>  		return tevent_req_post(req, ev);
>  	}
>  
> -	state->cli = cli;
>  	state->fnum = fnum;
>  
>  	status = map_fnum_to_smb2_handle(cli, fnum, &state->ph);
> -- 
> 2.1.4

This patch causes:

make test TESTS=samba3.blackbox.smbclient_s3.plain

to fail with

UNEXPECTED(failure): samba3.blackbox.smbclient_s3.plain (nt4_dc).creating a :stream at root of share(nt4_dc)

still investigating. I've pushed the others
(except for the one blocked by the gcc bug).