[PATCH] mostly clang warnings
Volker Lendecke
vl at samba.org
Wed Oct 19 08:36:56 UTC 2016
Andreas Schneider <asn at samba.org> writes:
> On Tuesday, 18 October 2016 11:18:48 CEST Jeremy Allison wrote:
> Then I would prefer:
>
> if (h1.data[0] != 0 || h1.data[1] != 0) {
> ...
> }
>
> It makes it clear while reading we are dealing with integers here. Also it
> tells me I want to check that it is not 0 and not something else. It is a just
> a readability thing and makes it easier on the eyes ;)
Unfortunately the version I posted went in. Do you insist on me fixing
that?
Thanks,
Volker
More information about the samba-technical
mailing list