[PATCH] Python3 compatible tests and credentials module

Andrew Bartlett abartlet at samba.org
Thu Nov 24 17:43:22 UTC 2016

On Thu, 2016-11-24 at 14:59 +0100, Lumir Balhar wrote:
> Hello.
> Because I have no response for two weeks on GitHub [0], I decided to 
> send my patches here. Which way is preferred, please?

Here is preferred.  There used to be a script the posted GitHub traffic
here, but clearly it is broken. 

I had started to look at your changes this week, but haven't got very
far yet.  

> The first part of this PR contains changes necessary to run tests
> with 
> Python 3. These changes should not have any impact on functionality
> with 
> Python 2.
> The second part ports the samba.credentials module to be Python 3 
> compatible, and also ports the credentials tests. The files
> py3compat.h 
> and compat.py will help us with porting and to make the future code
> more 
> readable. The py3compat.h file is the same as proposed by Petr
> Viktorin 
> and discussed in this thread: 
> https://lists.samba.org/archive/samba-technical/2016-July/114998.html
> I am submitting the two parts as one PR because, without at least
> one 
> module prepared for Python 3, it is impossible to try running tests
> with 
> Python 3.
> [0] https://github.com/samba-team/samba/pull/68
> Have a nice day.
> Lumír

Thank you so much for your patience and persistence.  If anyone else
here can help with the review, that would be most appreciated. 


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list