[PATCH] Python3 compatible tests and credentials module
abartlet at samba.org
Thu Nov 24 17:43:22 UTC 2016
On Thu, 2016-11-24 at 14:59 +0100, Lumir Balhar wrote:
> Because I have no response for two weeks on GitHub , I decided to
> send my patches here. Which way is preferred, please?
Here is preferred. There used to be a script the posted GitHub traffic
here, but clearly it is broken.
I had started to look at your changes this week, but haven't got very
> The first part of this PR contains changes necessary to run tests
> Python 3. These changes should not have any impact on functionality
> Python 2.
> The second part ports the samba.credentials module to be Python 3
> compatible, and also ports the credentials tests. The files
> and compat.py will help us with porting and to make the future code
> readable. The py3compat.h file is the same as proposed by Petr
> and discussed in this thread:
> I am submitting the two parts as one PR because, without at least
> module prepared for Python 3, it is impossible to try running tests
> Python 3.
>  https://github.com/samba-team/samba/pull/68
> Have a nice day.
Thank you so much for your patience and persistence. If anyone else
here can help with the review, that would be most appreciated.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical