[PATCH] Python3 compatible tests and credentials module

Lumir Balhar lbalhar at redhat.com
Thu Nov 24 13:59:39 UTC 2016


Hello.

Because I have no response for two weeks on GitHub [0], I decided to 
send my patches here. Which way is preferred, please?

The first part of this PR contains changes necessary to run tests with 
Python 3. These changes should not have any impact on functionality with 
Python 2.
The second part ports the samba.credentials module to be Python 3 
compatible, and also ports the credentials tests. The files py3compat.h 
and compat.py will help us with porting and to make the future code more 
readable. The py3compat.h file is the same as proposed by Petr Viktorin 
and discussed in this thread: 
https://lists.samba.org/archive/samba-technical/2016-July/114998.html

I am submitting the two parts as one PR because, without at least one 
module prepared for Python 3, it is impossible to try running tests with 
Python 3.

[0] https://github.com/samba-team/samba/pull/68

Have a nice day.
Lumír

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-wscript_build-Prepare-build-environment-for-P.patch
Type: text/x-patch
Size: 1182 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0001-python-wscript_build-Prepare-build-environment-for-P.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-python-Make-top-level-samba-modules-Python-3-compati.patch
Type: text/x-patch
Size: 9523 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0002-python-Make-top-level-samba-modules-Python-3-compati.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python-samba.tests.dcerpc-Move-Class-RawDCERPCTest-t.patch
Type: text/x-patch
Size: 73185 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0003-python-samba.tests.dcerpc-Move-Class-RawDCERPCTest-t.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-python-selftesthelpers-Add-possibility-for-planning-.patch
Type: text/x-patch
Size: 1852 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0004-python-selftesthelpers-Add-possibility-for-planning-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-python-samba.subunit.run-Fix-Python-3-compatibility.patch
Type: text/x-patch
Size: 1775 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0005-python-samba.subunit.run-Fix-Python-3-compatibility.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-python-Add-py3compat.h.patch
Type: text/x-patch
Size: 6184 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0006-python-Add-py3compat.h.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-python-samba.credentials-Port-pycredentials.c-to-Pyt.patch
Type: text/x-patch
Size: 3529 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0007-python-samba.credentials-Port-pycredentials.c-to-Pyt.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-python-credentials-wscript_build-Build-pycredentials.patch
Type: text/x-patch
Size: 1332 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0008-python-credentials-wscript_build-Build-pycredentials.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-python-samba.tests.credentials-Python-3-compatible-t.patch
Type: text/x-patch
Size: 11167 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0009-python-samba.tests.credentials-Python-3-compatible-t.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-python-selftest-Enable-Python-3-tests-for-samba.cred.patch
Type: text/x-patch
Size: 1036 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161124/d11fc125/0010-python-selftest-Enable-Python-3-tests-for-samba.cred.bin>


More information about the samba-technical mailing list