[PATCH] Avoid infinite recursion in KCC

garming at catalyst.net.nz garming at catalyst.net.nz
Thu Nov 17 12:14:52 UTC 2016


Can you put a better comment regarding what is contained in the database
(and how it was created), both in the test and in the commit message? 


On 07/11/16 16:12, Clive Ferreira wrote: 

> Hi,
> Included in these patches are a fix by Douglas Bagnall to correct a mix
> up made between a str and an object which caused infinite recursion and
> a method call on a None type.
> I added a test patch which uses a database dump file which originally
> triggered this edge case. This database consists of 5 unconnected DCs,
> and the bug is triggered by code to create additional edges which
> normally never ran. In normal cases, the leftover connections made
> during a join would prevent these additional edges from being created.
> cheers
> Clive

More information about the samba-technical mailing list