Default setting for "client max protocol" is NT1

[Andreas Schneider]

On Saturday, 5 November 2016 10:51:54 CET Stefan Metzmacher wrote:
> Am 04.11.2016 um 17:48 schrieb Jeremy Allison:
> > This was brought to my attention recently:
> > 
> > int lpcfg_client_max_protocol(struct loadparm_context *lp_ctx)
> > {
> > 
> > 	int client_max_protocol = lpcfg__client_max_protocol(lp_ctx);
> > 	if (client_max_protocol == PROTOCOL_DEFAULT) {
> > 	
> > 		return PROTOCOL_NT1;
> > 	
> > 	}
> > 	return client_max_protocol;
> > 
> > }
> > 
> > This is correct from the man page:
> >     <para>The value <constant>default</constant> refers to
> >     <constant>NT1</constant>.</para>> 
> > However - "client ipc max protocol" has:
> > 
> > int lpcfg_client_ipc_max_protocol(struct loadparm_context *lp_ctx)
> > {
> > 
> >         int client_ipc_max_protocol =
> >         lpcfg__client_ipc_max_protocol(lp_ctx);
> >         if (client_ipc_max_protocol == PROTOCOL_DEFAULT) {
> >         
> >                 return PROTOCOL_LATEST;
> >         
> >         }
> > 
> > ...
> > 
> > PROTOCOL_LATEST == PROTOCOL_SMB3_11. And indeed looking at the
> > 
> > man page we have:
> >     <para>The value <constant>default</constant> refers to the latest
> >     supported protocol, currently <constant>SMB3_11</constant>.</para>
> > 
> > Do we want to change the default for "client max protocol" to be
> > PROTOCOL_LATEST to match "client ipc max protocol" ?
> 
> Yes, we want that, but not until every feature that works against
> a Windows server with NT1 also work with SMB2/3.
> 
> There were several bug reports, I'm not sure if they're still open.
> 
> It would be really good to have all smbclient features tested in a
> blackbox test,


What I don't like is that we have a public interface and a private one. I 
would prefer to have one client library, libsmbclient and every tool we have 
should use that API. We could create python bindings for libsmbclient and 
write tests with python.


So we can have a complete testsuite for libsmbclient and have smaller blackbox 
tests for the tools itself.


It would also be much faster to run one python testsuite instead of calling 
smbclient a thousand times ...