Default setting for "client max protocol" is NT1

[Jeremy Allison]

On Sat, Nov 05, 2016 at 03:33:34PM +0100, Andreas Schneider wrote:
> 
> What I don't like is that we have a public interface and a private one. I 
> would prefer to have one client library, libsmbclient and every tool we have 
> should use that API. We could create python bindings for libsmbclient and 
> write tests with python.

Actually, this is one case where I think it's appropriate to
have a private interface (the cli_XXX one) underneath the
public one.

We often don't know exactly what the external interface
should look like long term (there have been some mistakes
there). Having smbclient call the internal interface allows
us to rapidly iterate and test versions of an interface
until we think it's good enough to go into the external
libsmbclient interface - then we can commit to support
it long term.

I'm certainly OK with doing the python bindings for
libsmbclient and testing with it - but we need the
ability to not have to live with our mistakes forever :-).

Jeremy.