s3:rpcclient add -m option (Re: [SCM] Samba Shared Repository - branch master updated)

[Stefan Metzmacher]

Am 20.05.2016 um 02:34 schrieb Jeremy Allison:
> On Thu, May 19, 2016 at 01:35:13PM +0200, Stefan Metzmacher wrote:
>> Hi Christian,
>>
>> I assume this patch was originally written before the badlock fixes.
>> As "client max protocol" should no longer being used in rpcclient.
>> We have "client ipc max protocol" which defaults to the latest supported
>> protocol
>> (currently SMB3_11).
>>
>> With the attached patches the following works:
>>
>> rpcclient --option="client ipc max protocol=SMB2_10" 172.31.9.163
>> -Uadministrator%A1b2C3d4 -c "getusername"
>> Account Name: Administrator, Authority Name: W4EDOM-L4
>>
>> rpcclient --option="client ipc max protocol=NT1" 172.31.9.163
>> -Uadministrator%A1b2C3d4 -c "getusername"
>> Account Name: Administrator, Authority Name: W4EDOM-L4
>>
>> rpcclient 172.31.9.163 -Uadministrator%A1b2C3d4 -c "getusername"
>> Account Name: Administrator, Authority Name: W4EDOM-L4
> 
> 
> These changes LGTM.
> 
> But might it be easier on the users to add an additional patch
> that makes '-m' on the rpcclient command line set 'client ipc max protocol' ?
> smbclient and smbcacls both use -m to set the max protocol - with rpcclient
> we could just change the ipc max protocol instead.

I'd try to avoid new options if possible and unlike the smb* commands it
really doesn't matter
much for an admin. I don't see a non-developer usecase for changing the
default.

Christian what was the purpose for adding this option?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160520/1968eac6/signature.sig>