[Review Request] binary suffix in search requests

Niklas Abel niklas.abel at lsexperts.de
Wed May 18 16:28:11 UTC 2016


Hey,

I have written a patch to fix the behavior previously discussed at

https://lists.samba.org/archive/samba/2015-November/196049.html


It modifies search requests with a ";binary" suffix.
If an attributes’ suffix is ";binary" the binary part will simple be
stripped away.

The code has been tested locally against NULL, empty strings,
with and without ";binary" part String behavior.

The attribute variable has not been fixed as recommended in resolve_oids.c
because the variable is static and can not be changed without
significant impact to the rest of the code.

Bye,
Niklas

-- 
Niklas Abel (IT Security Consultant), http://www.lsexperts.de
LSE Leading Security Experts GmbH, Postfach 100121, 64201 Darmstadt
Tel: +49 6151 86086-261, Fax: -299, Mobil: +49 151 26467737
Unternehmenssitz: Weiterstadt, Amtsgericht Darmstadt: HRB8649
Geschäftsführer: Nils Manegold, Oliver Michel, Arved Graf von Stackelberg, Sven Walther

-------------- next part --------------
A non-text attachment was scrubbed...
Name: binary-suffix.patch
Type: text/x-patch
Size: 2320 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160518/e7f2893e/binary-suffix.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3958 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160518/e7f2893e/smime.bin>


More information about the samba-technical mailing list