[Review Request] binary suffix in search requests

[Niklas Abel]

Hey,

are there any reasons in my mistake that the patch gets no attention?

Should I re-post the mail as new with the [Patch] prefix to the mailing
list?

Bye,
Niklas

On 05/18/2016 06:28 PM, Niklas Abel wrote:
> Hey,
>
> I have written a patch to fix the behavior previously discussed at
>
> https://lists.samba.org/archive/samba/2015-November/196049.html
>
>
> It modifies search requests with a ";binary" suffix.
> If an attributes’ suffix is ";binary" the binary part will simple be
> stripped away.
>
> The code has been tested locally against NULL, empty strings,
> with and without ";binary" part String behavior.
>
> The attribute variable has not been fixed as recommended in resolve_oids.c
> because the variable is static and can not be changed without
> significant impact to the rest of the code.
>
> Bye,
> Niklas
>

-- 
Niklas Abel (IT Security Consultant), http://www.lsexperts.de
LSE Leading Security Experts GmbH, Postfach 100121, 64201 Darmstadt
Tel: +49 6151 86086-261, Fax: -299, Mobil: +49 151 26467737
Unternehmenssitz: Weiterstadt, Amtsgericht Darmstadt: HRB8649
Geschäftsführer: Nils Manegold, Oliver Michel, Arved Graf von Stackelberg, Sven Walther

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3958 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160530/310cbd64/smime.bin>