[patchset] introduce an -O3 autobuild target - and fix a lot of errors

Christian Ambach ambi at samba.org
Thu May 12 16:28:16 UTC 2016


Hi Michael,


>> Patchset still applies/rebases cleanly after the sec.update.
> 
> Given we keep the extra target, can you just add an update to the
> .travis.yml as well would be great, so we test it on github pushes?
> 
> With that added, the autobuild.py changes are Reviewed-by: me, but the
> rest I'll leave for others to comment on.
The other patches are Reviewed-by: me. However, now errors have
shown up on my machine. I need the attached two additional patches.
Can you review them and then push everything together?

Christian


-------------- next part --------------
From 78b59b7c69746b35efcd28da5a7623465e08b3c8 Mon Sep 17 00:00:00 2001
From: Christian Ambach <ambi at samba.org>
Date: Sat, 2 Apr 2016 02:08:05 +0200
Subject: [PATCH 1/2] s3:modules/vfs_snapper squelch -O3 compile warning

Signed-off-by: Christian Ambach <ambi at samba.org>
---
 source3/modules/vfs_snapper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/modules/vfs_snapper.c b/source3/modules/vfs_snapper.c
index 64a83bd..07ec574 100644
--- a/source3/modules/vfs_snapper.c
+++ b/source3/modules/vfs_snapper.c
@@ -1856,7 +1856,7 @@ static NTSTATUS snapper_snap_path_expand(struct connection_struct *conn,
 	NTSTATUS status;
 	char *conf_name;
 	char *base_path;
-	char *snap_path;
+	char *snap_path = NULL;
 
 	dconn = snapper_dbus_conn_create();
 	if (dconn == NULL) {
-- 
1.9.1


From 8d80cd9f37f2d9c5b15a6ddffcedb6ede00e46d7 Mon Sep 17 00:00:00 2001
From: Christian Ambach <ambi at samba.org>
Date: Thu, 12 May 2016 17:10:51 +0200
Subject: [PATCH 2/2] s4:repl_meta_data: squelch compile warning with -O3

---
 source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 40bccac..f65cc65 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -3710,7 +3710,7 @@ static int replmd_op_name_modify_callback(struct ldb_request *req, struct ldb_re
 {
 	struct replmd_replicated_request *ar =
 		talloc_get_type_abort(req->context, struct replmd_replicated_request);
-	struct ldb_dn *conflict_dn;
+	struct ldb_dn *conflict_dn = NULL;
 	int ret;
 
 	if (ares->error != LDB_SUCCESS) {
-- 
1.9.1



More information about the samba-technical mailing list