[PATCH] changes to rpcclient

[Andreas Schneider]

On Wednesday, 18 May 2016 22:35:41 CEST Christian Ambach wrote:
> Hi Andreas,

Hi Christian,

> Am 12.05.16 um 11:41 schrieb Andreas Schneider:
> > Thank you very much for the test. As we talked about it yesterday, take a
> > look at https://lwn.net/Articles/558106/ which explains the mocking
> > functionality of cmocka.
> > 
> > For a start we could just check for cmocka using pkg-config and if we find
> > it enable the tests and run them ...
> > 
> > Note that you need:
> > 	cmocka_set_message_output(CM_OUTPUT_SUBUNIT);
> > 
> > so selftest can parse the results.
> 
> I started working with cmocka.
> Attached you can find my current work in progress. Does that look as if
> its heading into the right direction?

yes, this looks good. I think you should use pkg-config for cmocka.

However the usage or implementation of pkg-config in waf is really really 
strange! If you search for it and it is found you can't use it you need to 
call our strange CHECK_LIB functions.


However we should discuss if it is fine to look for cmocka on the system or if 
we need to add it to 3rdparty ...


Cheers,


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org