[PATCH] Restructure winbind xids2sids

[Jeremy Allison]

On Tue, Mar 29, 2016 at 09:28:19PM +0200, Volker Lendecke wrote:
> On Tue, Mar 29, 2016 at 09:56:12AM -0700, Jeremy Allison wrote:
> > On Mon, Mar 28, 2016 at 09:22:53PM +0200, Volker Lendecke wrote:
> > > Hi!
> > > 
> > > This is a patchset that passes down the xids2sids operation from the
> > > winbind frontend to the idmap backends.
> > > 
> > > Review appreciated!
> > 
> > Minor fix. In:
> > 
> > +struct id_map **id_map_ptrs_init(TALLOC_CTX *mem_ctx, size_t num_ids)
> > 
> > Error path for alloc fail on sids needs to also
> > free maps.
> > 
> > +       sids = talloc_zero_array(ptrs, struct dom_sid, num_ids);
> > +       if (sids == NULL) {
> > +               TALLOC_FREE(ptrs);
> > 
> > Needs		TALLOC_FREE(maps);
> > 
> > +               return NULL;
> > +       }
> 
> Don't think so. That's the point of this patch: Establish a talloc
> hierarchy.

Doh ! Sorry.... Missed the owner change...

Apologies :-).