[PATCH] Restructure winbind xids2sids

[Volker Lendecke]

On Tue, Mar 29, 2016 at 09:56:12AM -0700, Jeremy Allison wrote:
> On Mon, Mar 28, 2016 at 09:22:53PM +0200, Volker Lendecke wrote:
> > Hi!
> > 
> > This is a patchset that passes down the xids2sids operation from the
> > winbind frontend to the idmap backends.
> > 
> > Review appreciated!
> 
> Minor fix. In:
> 
> +struct id_map **id_map_ptrs_init(TALLOC_CTX *mem_ctx, size_t num_ids)
> 
> Error path for alloc fail on sids needs to also
> free maps.
> 
> +       sids = talloc_zero_array(ptrs, struct dom_sid, num_ids);
> +       if (sids == NULL) {
> +               TALLOC_FREE(ptrs);
> 
> Needs		TALLOC_FREE(maps);
> 
> +               return NULL;
> +       }

Don't think so. That's the point of this patch: Establish a talloc
hierarchy.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de