[PR PATCH] build:wafsamba: Remove ambiguous 'if x in conf.env' constructs

github at samba.org github at samba.org
Sat Mar 26 14:03:24 UTC 2016

There is a new pull request by ita1024 against master on the Samba Samba Github repository

https://github.com/ita1024/samba lift_ambiguous_construct

build:wafsamba: Remove ambiguous 'if x in conf.env' constructs
Configuration values such as HAVE_STDDEF_H can be set to 0
to indicate a test failure. Waf 1.5 has a few bugs that
prevent configuration tests from setting such values
consistently on failures.

Consequently, conditions such as 'if conf.env.VARNAME' must be
used to indicate that config test successes are expected.
Note that conf.env.VARNAME always returns an empty list (False value)
when no variable is defined so there are no risk of raising
AttributeError/KeyError exceptions.

A patch file from https://github.com/samba-team/samba/pull/56.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-lift_ambiguous_construct-56.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160326/841914cb/github-pr-lift_ambiguous_construct-56.patch>

More information about the samba-technical mailing list