[PATCH] torture: Fix the O3 developer build

Andreas Schneider asn at samba.org
Wed Mar 23 07:06:20 UTC 2016


On Tuesday 22 March 2016 22:28:14 Michael Adam wrote:
> On 2016-03-22 at 13:38 -0700, Jeremy Allison wrote:
> > On Tue, Mar 22, 2016 at 06:41:42PM +0100, Michael Adam wrote:
> > > On 2016-03-22 at 17:20 +0100, Volker Lendecke wrote:
> > > > On Tue, Mar 22, 2016 at 05:05:55PM +0100, Michael Adam wrote:
> > > > > On 2016-03-22 at 08:50 -0700, Jeremy Allison wrote:
> > > > > > On Tue, Mar 22, 2016 at 04:05:50PM +0100, Volker Lendecke wrote:
> > > > > > > Hi!
> > > > > > > 
> > > > > > > Apologies for the repeated mails in this regard: Is anybody on
> > > > > > > this list
> > > > > > > still interested in this kind of spam, or do you want me to keep
> > > > > > > them
> > > > > > > local in my tree?
> > > > > > 
> > > > > > Yes, yes 1000x yes - please keep them coming :-).
> > > > > 
> > > > > Indeed... Jeremy was again faster... :-)
> > > > > 
> > > > > I guess the actual message (instead of apologies) was
> > > > > "When will you guys finally be careful enough with the code
> > > > > you write, so that I don't have to fix up behind you?..."
> > > > 
> > > > Right. The question really is -- if I'm the only one compiling with
> > > > -O3 for the additional warnings, the Samba Team as a whole does not
> > > > see this as a priority.
> > > 
> > > We are all just lazy farts, and not implicitly neglcting -O3 but
> > > relying on you... I propose that we add a -O3 build target
> > > to our autobuild, so that there are no excuses.
> > > 
> > > See the attached patch.
> > > 
> > > Note that this fails on my f23 box... need to fix a few
> > > O3 bugs as it seems ... :-)
> > 
> > Let's fix those as well, then push the whole thing :-).
> 
> Ok ... Now this updated patch survices autobuild on my box.
> 
> Changes:
> 
> - Volker's previous patch to torture/smb2/replay.c was applied first :-)
> 
> - I had to add "--abi-check-disable" to configure to survice the
>   build -- not sure if abi check is expected to fail if building
>   with -O3 ?

The ABI check is broken on Fedora because of a GCC 5.x bug. I've already 
debugged it and opened a bug for the issue:


https://bugzilla.redhat.com/show_bug.cgi?id=1283746


	-- andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list