samba4.ldap.notification.python flapping

[Andrew Bartlett]

On Tue, 2016-03-22 at 08:25 +0100, Stefan Metzmacher wrote:
> Hi Andrew,
> 
> > 
> > UNEXPECTED(failure):
> > samba4.ldap.notification.python(ad_dc_ntvfs).__main__.LDAPNotificat
> > ionT
> > est.test_max_search(ad_dc_ntvfs)
> > REASON: Exception: Exception: Traceback (most recent call last):
> >   File
> > "/home/ubuntu/autobuild/b26522/samba/source4/dsdb/tests/python/noti
> > fica
> > tion.py", line 187, in test_max_search
> >     self.assertEqual(num_admin_limit, 1)
> > AssertionError: 0 != 1
> > 
> > I know you are really busy, so I'm going to try and fix this
> > myself:
> > Can I make the timeout 5 here, without affecting the test intent?
> Yes, maybe try with 2 or 3 seconds first...

I've tried all sorts of things, and I can't make this work, so I'm
marking it flapping with the attached patch.   Please review.

I've seen 6 requests go in and have all followed up with a timeout, and
no error, I've seen the first and last requests fail (before we fixed
the >=).  I've seen the new test pass, and fail.  I can't make any
sense of the async foo in the LDAP server, so I just need this go get
out of the way of our other work.

I realise you are very busy also, so please just take this as a heads-
up, and get back to it when you have a few spare hours (given my
experience, but of course you know your own code better).

On the plus side, I can make this fail inside testenv 1/3 times, so you
don't need to wait for a full failed autobuild.

Sorry,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-notification.py-Increase-timeout-in-test_ma.patch
Type: text/x-patch
Size: 1201 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160323/f2b4d1f9/0001-selftest-notification.py-Increase-timeout-in-test_ma.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-selftest-Improve-ldap.notification-max_search-test.patch
Type: text/x-patch
Size: 3585 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160323/f2b4d1f9/0002-selftest-Improve-ldap.notification-max_search-test.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-selftest-Mark-LDAPNotificationTest.test_max_search-f.patch
Type: text/x-patch
Size: 964 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160323/f2b4d1f9/0003-selftest-Mark-LDAPNotificationTest.test_max_search-f.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160323/f2b4d1f9/signature.sig>