[PATCH] ctdb-client: Increase the timeout for TRANS3_COMMIT control

Amitay Isaacs amitay at gmail.com
Fri Mar 11 03:03:11 UTC 2016


On a busy system, TRANS3_COMMIT control can take upto or longer than
3 seconds.  On timeout, there are few possible outcomes.

1. The transaction has completed on all nodes and TRANS3_COMMIT control
   has returned.  In such a case, there is no problem.

2. The transaction has completed on the local node, but TRANS3_COMMIT
   control is still active.  In such a case, ctdb_transaction_commit()
   can return successfully.  If this is being called from ctdb, then
   ctdb will exit.  This will cause ctdb daemon to trigger recovery
   since the client exited while transaction is active.  This will cause
   unnecessary recovery.

3. Database recovery was started and ctdb_transaction_commit() will
   retry till the recovery completes the transaction.

Increasing the timeout to 30 seconds will avoid the spurious database
recoveries when TRANS3_COMMIT control takes longer to finish.

Please review and push.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-client-Increase-the-timeout-for-TRANS3_COMMIT-c.patch
Type: application/text
Size: 1718 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160311/7e59d259/0001-ctdb-client-Increase-the-timeout-for-TRANS3_COMMIT-c.bin>

More information about the samba-technical mailing list