samba4.ldap.notification.python flapping

[Andrew Bartlett]

On Fri, 2016-03-11 at 10:21 +0100, Stefan Metzmacher wrote:
> Am 11.03.2016 um 05:00 schrieb Andrew Bartlett:
> > 
> > On Fri, 2016-03-11 at 16:22 +1300, Andrew Bartlett wrote:
> > > 
> > > On Fri, 2016-03-11 at 02:45 +0100, Stefan Metzmacher wrote:
> > > > 
> > > > > 
> > > > > Error 3 is TIME_LIMIT_EXCEEDED.  Perhaps you can look into
> > > > > why
> > > > > this
> > > > > might happen?
> > > > Because the server is too busy/slow :-(
> > > Yeah, we push our VM pretty hard.  The whole autobuild works in a
> > > 2
> > > CPU, 4GB RAM VM. 
> > > 
> > > > 
> > > > 
> > > > In source4/dsdb/tests/python/notification.py, we need to change
> > > > timeout=1 into timeout=2 (or similar) everywhere we don't
> > > > expect
> > > > ERR_TIME_LIMIT_EXCEEDED.
> > > OK. Thanks,
> I looked at it again and I think the following patch should
> fix the flapping test.
> 
> We can't be sure the 5+1 async requests arrive at the server in
> exactly the order the client submitted them.
> 
> We just need to make sure 5 return ERR_TIME_LIMIT_EXCEEDED and
> one returns ERR_ADMIN_LIMIT_EXCEEDED.
> 
> Please review and push:-)

I'm sorry, but I've still seen this one flap.  It isn't a major
priority to fix, but if you think about this one when you get a moment,
let me know:

UNEXPECTED(failure):
samba4.ldap.notification.python(ad_dc_ntvfs).__main__.LDAPNotificationT
est.test_max_search(ad_dc_ntvfs)
REASON: Exception: Exception: Traceback (most recent call last):
  File
"/home/ubuntu/autobuild/b27019/samba/source4/dsdb/tests/python/notifica
tion.py", line 187, in test_max_search
    self.assertEqual(num_admin_limit, 1)
AssertionError: 2 != 1

This is on the catalyst cloud, so I'll give my testing VMs some more
memory in the hope that fixes things.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160322/46f4c559/signature.sig>