samba4.ldap.notification.python flapping

[Stefan Metzmacher]

Hi,

please have a look at the patches on the
"Summary of flapping tests on sn-devel" thread.

There're updated patches...

metze

Am 11.03.2016 um 10:21 schrieb Stefan Metzmacher:
> Am 11.03.2016 um 05:00 schrieb Andrew Bartlett:
>> On Fri, 2016-03-11 at 16:22 +1300, Andrew Bartlett wrote:
>>> On Fri, 2016-03-11 at 02:45 +0100, Stefan Metzmacher wrote:
>>>>
>>>> Hi Andrew,
>>>>
>>>>>
>>>>>
>>>>> Just a heads-up that I've seen this test fail spuriously on the
>>>>> Catalyst Cloud.  
>>>>>
>>>>> (Between all the different flapping tests, we get success about
>>>>> 20-
>>>>> 30%
>>>>> of the time. )
>>>> I also got that already...
>>>>
>>>>>
>>>>>
>>>>> Error 3 is TIME_LIMIT_EXCEEDED.  Perhaps you can look into why
>>>>> this
>>>>> might happen?
>>>> Because the server is too busy/slow :-(
>>> Yeah, we push our VM pretty hard.  The whole autobuild works in a 2
>>> CPU, 4GB RAM VM. 
>>>
>>>>
>>>> In source4/dsdb/tests/python/notification.py, we need to change
>>>> timeout=1 into timeout=2 (or similar) everywhere we don't expect
>>>> ERR_TIME_LIMIT_EXCEEDED.
>>> OK. Thanks,
> 
> I looked at it again and I think the following patch should
> fix the flapping test.
> 
> We can't be sure the 5+1 async requests arrive at the server in
> exactly the order the client submitted them.
> 
> We just need to make sure 5 return ERR_TIME_LIMIT_EXCEEDED and
> one returns ERR_ADMIN_LIMIT_EXCEEDED.
> 
> Please review and push:-)
> 
> Thanks!
> metze
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160311/654a5fb7/signature.sig>