[PATCH] Remove strcpy() from most Team-controlled code.

Jeremy Allison jra at samba.org
Mon Mar 21 17:35:21 UTC 2016

On Sat, Mar 19, 2016 at 11:21:47AM +1100, Martin Schwenke wrote:
> Yeah, we'll get there.  Some of the code in the ctdb CLI tool (written
> by me) uses strcpy(3) (perhaps even technically incorrectly) because it
> is simple and obvious. There is a buffer declared, there are a finite
> number of strings declared nearby that can be concatenated into the
> buffer.  It will fit.  You'd have to be trying hard to change
> the code so it actually breaks and overflows the buffer.  More famous
> last words!  I'll take another look at my patch for it on Monday and
> probably post it... and then Amitay will throw it all away when he
> finally gets time to apply the final tweaks to his replacement...  :-)
> peace & happiness,
> martin

LGTM. Pushed ! Thanks.

More information about the samba-technical mailing list