[PATCH] Remove strcpy() from most Team-controlled code.
jra at samba.org
Mon Mar 21 17:33:26 UTC 2016
On Thu, Mar 17, 2016 at 01:03:24PM -0700, Jeremy Allison wrote:
> On Thu, Mar 17, 2016 at 12:53:27PM -0700, Jeremy Allison wrote:
> > Removes uses of strcpy() (even though these were
> > safe) from most Team code. I'd like to excise all
> > strcpy() instances even from test and example code
> > as good security policy.
> > Had to leave the use inside examples/validchars/validchr.c
> > as that's a DOS-end-of-line CR/LF file and I couldn't
> > figure out how to create a git-am patch that would
> > cleanly apply to a checked out branch without causing
> > a "inconsistent EOL" error in the patch process.
> > There are still some in ctdb I haven't gotten to
> > yet.
> > Passes local make test.
> > Please review and push if happy !
> Bah. Sent the previous version of the patch (sorry).
> One character change and this is the correct one
> (doubt if anyone'll spot it, but I want this to
> be correct :-).
> Here's the correct patch !
Ping. Can I get a review on this one please ?
More information about the samba-technical