Supporting file systems that have support for CREATE TIME and DOS Attributes

Richard Sharpe realrichardsharpe at gmail.com
Fri Mar 18 23:32:16 UTC 2016


On Fri, Mar 18, 2016 at 4:22 PM, Jeremy Allison <jra at samba.org> wrote:
> On Fri, Mar 18, 2016 at 04:09:09PM -0700, Richard Sharpe wrote:
>> Hi folks,
>>
>> There are a couple of file systems or systems that support CREATE TIME
>> as a separate time (ie FreeBSD, ZFS, etc.)
>>
>> Also, ZFS supports the notion of DOS Attributes and other things like
>> a QUARANTINE bit in the ZNODE.
>>
>> While we can handle create time easily by implementing ntimes in our
>> VFS module, it is hard to handle DOS Attributes without modifying
>> Samba.
>>
>> Can we refactor file_set_dosmode so it uses something like
>> SMB_VFS_SET_DOS_ATTRS etc and then move the current behavior into
>> vfs_default.c?
>
> Yes, that makes sense. Can you make 2 calls:
>
> SMB_VFS_SET_DOS_ATTRIBUTES()
> SMB_VFS_FSET_DOS_ATTRIBUTES()
>
> so we have a path + handle version ?
>
> Make the path based version take a
> const struct smb_filename *, not a
> const char *.

Heh, yeah.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list