Supporting file systems that have support for CREATE TIME and DOS Attributes

Jeremy Allison jra at samba.org
Fri Mar 18 23:22:20 UTC 2016


On Fri, Mar 18, 2016 at 04:09:09PM -0700, Richard Sharpe wrote:
> Hi folks,
> 
> There are a couple of file systems or systems that support CREATE TIME
> as a separate time (ie FreeBSD, ZFS, etc.)
> 
> Also, ZFS supports the notion of DOS Attributes and other things like
> a QUARANTINE bit in the ZNODE.
> 
> While we can handle create time easily by implementing ntimes in our
> VFS module, it is hard to handle DOS Attributes without modifying
> Samba.
> 
> Can we refactor file_set_dosmode so it uses something like
> SMB_VFS_SET_DOS_ATTRS etc and then move the current behavior into
> vfs_default.c?

Yes, that makes sense. Can you make 2 calls:

SMB_VFS_SET_DOS_ATTRIBUTES()
SMB_VFS_FSET_DOS_ATTRIBUTES()

so we have a path + handle version ?

Make the path based version take a
const struct smb_filename *, not a
const char *.



More information about the samba-technical mailing list