Summary of flapping tests on sn-devel

[Andrew Bartlett]

On Fri, 2016-03-11 at 13:03 +0100, Stefan Metzmacher wrote:
> Hi Douglas,
> 
> thanks for the summary!
> 
> > There is a little script at
> > http://git.catalyst.net.nz/gitweb?p=samba-cloud-autobuild.git;a=blo
> > b;f=parse-email/parse-autobuild-email;hb=refs/heads/heat
> > that reads a mailbox directory containing autobuild failure emails,
> > collects the logs from the server, and prints counts of the common
> > failure messages. You can restrict it to recent failures, as in
> > this
> > example where it shows the 8 worst offenders since a month ago:
> > 
> > $ ./parse-email/parse-autobuild-email  --since 2016-02-11 -c 8
> > found 97 lines matching '^UNEXPECTED' in 125 files matching
> > 'samba.stdout$'
> >   41 UNEXPECTED(failure):
> > samba4.winbind.struct.domain_info(ad_member:local)
> 
> It's sad, as I spend hours on debugging this (without success),
> but I think we should mark this as flapping,

OK.  One way out of this would be to fix our NETLOGON server not to
return 127.0.0.1 as the address of all trusted domains.  We still
shouldn't let a spoofed domain get into winbind's cache, but part of
that is due to it accepting out machine password, because while it is
the 'wrong' domain, it is outself, so we of course take our own PW.

> >   11 UNEXPECTED(failure):
> > samba4.ldap.notification.python(ad_dc_ntvfs).__main__.LDAPNotificat
> > ionTest.test_max_search(ad_dc_ntvfs)
> 
> I just posted a fix for that.
> 
> >    7 UNEXPECTED(failure): samba4.blackbox.dbcheck.release-4-1
> > -0rc3.check_expected_after_dup_values(none)
> 
> I think that's the local-attid problem andrew was about to fix,
> right?

No, this one is already fixed, but there are other flapping dbcheck
issues, the one I posted the local-attid patch for, and a replication
rename/parent issue I'm working on and will have patches for soon.

> >    4 UNEXPECTED(failure): samba3.unix.whoami machine
> > account.whoami(nt4_member:local)
> >    3 UNEXPECTED(failure): samba3.blackbox.smbclient_s3.plain
> > (ad_member) member creds.sending a message to the remote
> > server(ad_member)
> >    3 UNEXPECTED(failure): samba3.wbinfo_simple.(ad_member:local).-
> > -krb5auth=SAMBADOMAIN/Administrator%locDCpass1.wbinfo(ad_member:loc
> > al)
> >    3 UNEXPECTED(failure):
> > samba3.rpc.spoolss.printer.addprinter.sd(ad_dc)
> >    2 UNEXPECTED(failure): samba4.rpc.backupkey with
> > seal.backupkey.unable_to_decrypt_secret(ad_dc_ntvfs)
> 
> That's the one you (or Garming?) tried to fix a few days ago, right?

Yes.  More patches needed for some of the other cases, but that is the
right style of fix.

> I've also (hopefully) fixed the new problem with python 2.6:
> [1804(11085)/1902 at 1h57m2s]
> samba4.ldap.sort.python(ad_dc_ntvfs)(ad_dc_ntvfs)
> Traceback (most recent call last):
>   File
> "/memdisk/autobuild/fl/b3372584/samba/source4/dsdb/tests/python/sort.
> py", line
> 8, in <module>
>     from collections import Counter
> ImportError: cannot import name Counter
> command: python
> /memdisk/autobuild/fl/b3372584/samba/source4/dsdb/tests/python/sort.p
> y
> $SERVER -U"$USERNAME%$PASSWORD" --workgroup=$DOMAIN $LOADLIST  2>&1 
>  |
> /memdisk/autobuild/fl/b3372584/samba/selftest/filter-subunit
> --fail-on-empty --prefix="samba4.ldap.sort.python(ad_dc_ntvfs)."
> --suffix="(ad_dc_ntvfs)"
> expanded command: python
> /memdisk/autobuild/fl/b3372584/samba/source4/dsdb/tests/python/sort.p
> y
> localdc -U"Administrator%locDCpass1" --workgroup=SAMBADOMAIN
> $LOADLIST
> 2>&1  | /memdisk/autobuild/fl/b3372584/samba/selftest/filter-subunit
> --fail-on-empty --prefix="samba4.ldap.sort.python(ad_dc_ntvfs)."
> --suffix="(ad_dc_ntvfs)"
> ERROR: Testsuite[samba4.ldap.sort.python(ad_dc_ntvfs)(ad_dc_ntvfs)]
> REASON: Exit code was 1
> 
> See
> https://git.samba.org/autobuild.flakey.sn-devel-104/2016-03-11-1019/s
> amba.stdout
> 
> I've attached all patches including the ldap.notification change.
> 
> Please have a look.
> 
> Can we also get someone else to review and push these?

Done.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba