[PATCH] Enhance vfs_fruit manpage and testparm checks for vfs_fruit stuff
jra at samba.org
Wed Mar 9 17:21:26 UTC 2016
On Wed, Mar 09, 2016 at 06:04:07PM +0100, Ralph Boehme wrote:
> On Wed, Mar 09, 2016 at 08:47:26AM -0800, Jeremy Allison wrote:
> > On Wed, Mar 09, 2016 at 05:19:05PM +0100, Ralph Boehme wrote:
> > > Hi!
> > >
> > > Attached is a patchset that adds some important information to the
> > > vfs_fruit manpage and adds checks to testparm that cover this.
> > >
> > > Please review & push if ok. Thanks!
> > LGTM. Pushed.
> > Minor complain. I *hate* new static's, although I can
> > see why you used them :-).
> > Lemme think if there's a better way (can't see one
> > right now though...).
> create a state in the caller and pass it to the function and then do
> the check in the caller, not the function. But is that really
> necessary for testparm?
Yeah, that's what I thought too. But came to the
But are we just being lazy and incurring a technical
debt we'll have to pay later ?
More information about the samba-technical