[PATCH] Enhance vfs_fruit manpage and testparm checks for vfs_fruit stuff

Ralph Boehme rb at sernet.de
Wed Mar 9 17:04:07 UTC 2016

On Wed, Mar 09, 2016 at 08:47:26AM -0800, Jeremy Allison wrote:
> On Wed, Mar 09, 2016 at 05:19:05PM +0100, Ralph Boehme wrote:
> > Hi!
> > 
> > Attached is a patchset that adds some important information to the
> > vfs_fruit manpage and adds checks to testparm that cover this.
> > 
> > Please review & push if ok. Thanks!
> LGTM. Pushed.


> Minor complain. I *hate* new static's, although I can
> see why you used them :-).
> Lemme think if there's a better way (can't see one
> right now though...).

create a state in the caller and pass it to the function and then do
the check in the caller, not the function. But is that really
necessary for testparm?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list