[PATCH] small refactorings to smbXsrv_open

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Mar 7 06:46:06 UTC 2016

On Fri, Feb 26, 2016 at 04:56:50PM +0100, Michael Adam wrote:
> > With these checks in place I immediately look for the circumstances when
> > "db" can be NULL.
> Heh, my reflex is to start verifying that all callers pass db != NULL
> if I see a function withOUT such checks. ;-)
> > If in the future this needs to be legitimately calleable
> > without a db, then we can add it. But for that we need to really make
> > sure we understand why we need a "db fetch" call without a db in the
> > first place.
> Updated patchset attached.

r-b me.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list