[PATCH] CTDB build cleanups

[Martin Schwenke]

On Mon, 7 Mar 2016 11:46:27 +1100, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Mon, Mar 7, 2016 at 6:18 AM, Martin Schwenke <martin at meltin.net> wrote:
> 
> > On Tue, 1 Mar 2016 20:12:53 +1100, Martin Schwenke <martin at meltin.net>
> > wrote:
> >  
> > > [PATCH 1/2] ctdb-packaging: Set --libexecdir in RPM spec file
> > > [PATCH 2/2] ctdb-packaging: Drop changelog section from RPM spec file
> > >
> > > I've tested (2) on Debian and RHEL6.  Does rpmbuild anywhere insist on
> > > %changelog?  Anyway, we're not building official distro packages.
> > >
> > > Please review and maybe push...  
> >
> > Reposting with improved, more convincing commit messages...  :-)

> NACK on the first patch.  On RPM based systems, %{_libexecdir} is defined
> as %{_exec_prefix}/libexec, which is derived from --prefix option.  Also,
> waf defines libexecdir, program executables, ${EXEC_PREFIX}/libexec which
> matches the RPM based systems.  So I see no reason for additional flags to
> configure.
> 
> To keep the configure line simple, pass only the options which defer from
> their default or derivation based on PREFIX.  For example --mandir or
> --localstatedir.  We do pass --sysconfdir even though rpm defines as /etc,
> but waf defines as sysconfdir, read-only single-machine data, ${PREFIX}/etc.
> 
> Building RPMs on debian system is just wrong and should not be considered
> as a reason for fixing anything.

Once more with feeling... and a relevant example (SUSE) where
_libexecdir defaults to something other than /usr/libexec   :-)

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-packaging-Set-libexecdir-in-RPM-spec-file.patch
Type: text/x-patch
Size: 1397 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160307/311f2535/0001-ctdb-packaging-Set-libexecdir-in-RPM-spec-file.bin>