[PATCH] CTDB build cleanups

Amitay Isaacs amitay at gmail.com
Mon Mar 7 00:46:27 UTC 2016

On Mon, Mar 7, 2016 at 6:18 AM, Martin Schwenke <martin at meltin.net> wrote:

> On Tue, 1 Mar 2016 20:12:53 +1100, Martin Schwenke <martin at meltin.net>
> wrote:
> > [PATCH 1/2] ctdb-packaging: Set --libexecdir in RPM spec file
> > [PATCH 2/2] ctdb-packaging: Drop changelog section from RPM spec file
> >
> > I've tested (2) on Debian and RHEL6.  Does rpmbuild anywhere insist on
> > %changelog?  Anyway, we're not building official distro packages.
> >
> > Please review and maybe push...
> Reposting with improved, more convincing commit messages...  :-)
> peace & happiness,
> martin

NACK on the first patch.  On RPM based systems, %{_libexecdir} is defined
as %{_exec_prefix}/libexec, which is derived from --prefix option.  Also,
waf defines libexecdir, program executables, ${EXEC_PREFIX}/libexec which
matches the RPM based systems.  So I see no reason for additional flags to

To keep the configure line simple, pass only the options which defer from
their default or derivation based on PREFIX.  For example --mandir or
--localstatedir.  We do pass --sysconfdir even though rpm defines as /etc,
but waf defines as sysconfdir, read-only single-machine data, ${PREFIX}/etc.

Building RPMs on debian system is just wrong and should not be considered
as a reason for fixing anything.

I have pushed the second patch.


More information about the samba-technical mailing list