[PATCH] Fix crash in net ads keytab create.
Uri Simchoni
uri at samba.org
Thu Jun 9 07:15:35 UTC 2016
On 06/09/2016 01:12 AM, Jeremy Allison wrote:
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=11959
>
> The done: label in ads_keytab_create_default() can be
> jumped to with krb5_context context = NULL, and then
> can use it in krb calls.
>
> Now the code in master is probably safe from this,
> as it initializes krb5_kt_cursor cursor = {0};
> and krb5_keytab_entry kt_entry = {0}, but it's
> very error-prone programming to not check every
> referenced pointer before use in error cleanup.
>
> Second Team member review appreciated.
>
> Cheers,
>
> Jeremy.
>
RB+ me and pushed.
Thanks,
Uri.
More information about the samba-technical
mailing list