[PATCH] Fix crash in net ads keytab create.

Jeremy Allison jra at samba.org
Wed Jun 8 22:12:35 UTC 2016

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11959

The done: label in ads_keytab_create_default() can be
jumped to with krb5_context context = NULL, and then
can use it in krb calls.

Now the code in master is probably safe from this,
as it initializes krb5_kt_cursor cursor = {0};
and krb5_keytab_entry kt_entry = {0}, but it's
very error-prone programming to not check every
referenced pointer before use in error cleanup.

Second Team member review appreciated.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-krb5-keytab-The-done-label-can-be-jumped-to-with-.patch
Type: text/x-diff
Size: 1445 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160608/6eee6e26/0001-s3-krb5-keytab-The-done-label-can-be-jumped-to-with-.diff>

More information about the samba-technical mailing list