[PATCH] ctdb-recoverd: Avoid duplicate recoverd event in parallel recovery

Ralph Boehme slow at samba.org
Wed Jun 8 07:37:44 UTC 2016


On Wed, Jun 08, 2016 at 02:49:46PM +1000, Martin Schwenke wrote:
> On Wed, 8 Jun 2016 14:46:56 +1000, Amitay Isaacs <amitay at gmail.com>
> wrote:
> 
> > In do_recovery, after the recovery and takeover is complete, recoverd
> > event is triggered.  When the parallel database recovery was separated,
> > ctdb_recovery_helper implemented sending END_RECOVERY control which
> > causes recoverd event to be triggered.  So when there is parallel database
> > recovery, recoverd event is triggered twice.
> > 
> > Instead move the call to run_recovered_eventscript() explicitly in
> > the serial recovery code path.  This avoids the duplication trigger of
> > recoverd event.
> > 
> > Please review and push.
> 
> Reviewed-by: Martin Schwenke <martin at meltin.net>

this sound like it would be good to have it in 4.4, right?

Cheerio!
-slow



More information about the samba-technical mailing list