[PATCH] ctdb-recoverd: Avoid duplicate recoverd event in parallel recovery
amitay at gmail.com
Wed Jun 8 13:50:38 UTC 2016
On Wed, Jun 8, 2016 at 5:37 PM, Ralph Boehme <slow at samba.org> wrote:
> On Wed, Jun 08, 2016 at 02:49:46PM +1000, Martin Schwenke wrote:
> > On Wed, 8 Jun 2016 14:46:56 +1000, Amitay Isaacs <amitay at gmail.com>
> > wrote:
> > > In do_recovery, after the recovery and takeover is complete, recoverd
> > > event is triggered. When the parallel database recovery was separated,
> > > ctdb_recovery_helper implemented sending END_RECOVERY control which
> > > causes recoverd event to be triggered. So when there is parallel
> > > recovery, recoverd event is triggered twice.
> > >
> > > Instead move the call to run_recovered_eventscript() explicitly in
> > > the serial recovery code path. This avoids the duplication trigger of
> > > recoverd event.
> > >
> > > Please review and push.
> > Reviewed-by: Martin Schwenke <martin at meltin.net>
> this sound like it would be good to have it in 4.4, right?
Yes, I have opened a defect for this one.
More information about the samba-technical