[PATCH] Improve performance of GUID_to_ndr_blob() and similar

[Andrew Bartlett]

On Mon, 2016-07-25 at 07:55 +0200, Volker Lendecke wrote:
> On Mon, Jul 25, 2016 at 04:10:41PM +1200, Andrew Bartlett wrote:
> > Here we avoid a talloc, reduce the other from 1024 to 16 bytes and
> > avoid a talloc_steal().
> > 
> > This helps in tight loops in the AD DC ldb layers, particularly
> > during
> > DRS replication of large numbers of links.  These O(N^2) loops
> > should
> > be addressed as well, but this fix will also help in many other
> > cases. 
> > 
> > Then, in the other patches, avoid talloc when not required
> > elsewhere in
> > ldb extended DN parsing.
> > 
> > Please review and push.
> 
> This looks good, but I would like to see the attached diff applied
> before it is pushed.

I've fixed that in the attached.

Please review/push!

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: less-talloc-in-libndr.patch
Type: text/x-patch
Size: 320 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160728/4c86fdc9/less-talloc-in-libndr.bin>