[PATCH] Improve performance of GUID_to_ndr_blob() and similar

Andrew Bartlett abartlet at samba.org
Mon Jul 25 19:27:39 UTC 2016


On Mon, 2016-07-25 at 07:55 +0200, Volker Lendecke wrote:
> On Mon, Jul 25, 2016 at 04:10:41PM +1200, Andrew Bartlett wrote:
> > Here we avoid a talloc, reduce the other from 1024 to 16 bytes and
> > avoid a talloc_steal().
> > 
> > This helps in tight loops in the AD DC ldb layers, particularly
> > during
> > DRS replication of large numbers of links.  These O(N^2) loops
> > should
> > be addressed as well, but this fix will also help in many other
> > cases. 
> > 
> > Then, in the other patches, avoid talloc when not required
> > elsewhere in
> > ldb extended DN parsing.
> > 
> > Please review and push.
> 
> This looks good, but I would like to see the attached diff applied
> before it is pushed.
> 
> Thanks, Volker

Thanks Volker.  I'll sort this out and get it landed today.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba






More information about the samba-technical mailing list