[WIP][PATCH] Improve tdb add/modify/delete loop perf by almost 20%

[Stefan Metzmacher]

Am 26.07.2016 um 21:23 schrieb Stefan Metzmacher:
> Hi Andrew,
> 
> I guess you have a logic bug in the following:
> 
>> +	if (ctx->unpack_flags & LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC) {
>> +		struct ldb_val data_talloc = {
>> +			.data = talloc_memdup(ctx->msg,
>> +					      data.dptr,
>> +					      data.dsize),
>> +			.length = data.dsize
>> +		};
> 
> 
> I changed the logic a bit to make it more clear why we do a memdup()
> on LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC.
> 
> See
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master-tmp
> 
> It has the version bumps for tdb, talloc, tevent and ldb ready to go
> for 4.5.0rc1.
> 
> Please push if you're happy with the result.

BTW: I temporary added ldb_unpack_data_only_attr_list_flags() to
lib/ldb/ABI/ldb-1.1.26.sigs and removed it with the version bump
to 1.1.27 in order to get a nice "ldb: version 1.1.27" commit.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160726/ee3db76c/signature.sig>