[WIP][PATCH] Improve tdb add/modify/delete loop perf by almost 20%

Stefan Metzmacher metze at samba.org
Tue Jul 26 19:23:28 UTC 2016


Hi Andrew,

I guess you have a logic bug in the following:

> +	if (ctx->unpack_flags & LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC) {
> +		struct ldb_val data_talloc = {
> +			.data = talloc_memdup(ctx->msg,
> +					      data.dptr,
> +					      data.dsize),
> +			.length = data.dsize
> +		};


I changed the logic a bit to make it more clear why we do a memdup()
on LDB_UNPACK_DATA_FLAG_NO_DATA_ALLOC.

See
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master-tmp

It has the version bumps for tdb, talloc, tevent and ldb ready to go
for 4.5.0rc1.

Please push if you're happy with the result.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160726/85baf992/signature.sig>


More information about the samba-technical mailing list