[PATCH] [WIP] Attempt to address flapping tests and file/directory mixups

Jeremy Allison jra at samba.org
Wed Jul 20 23:44:50 UTC 2016

On Wed, Jul 20, 2016 at 04:17:09PM -0700, Jeremy Allison wrote:
> On Thu, Jul 21, 2016 at 06:56:39AM +1200, Andrew Bartlett wrote:
> > I've been thinking about the flapping tests, and I think it might be
> > dev/inode re-use in vfs_xattr_tdb.
> > 
> > The fix should be simple: whenever we create a file, wipe the DB before
> > we return the file handle. 
> > 
> > I can't get the first attached test to pass samba3.base.delete for some
> > reason, and the second is really just a paper-over effort, so I
> > wondered if a smbd wizard could help me work out why this doesn't work?
> > 
> > Finally, if it is dev/inode re-use, that could be the reason we don't
> > see this as often away from sn-devel.
> Think I've found it - we use xattrs to store user.DOSATTRIB on a
> newly created file. If you wipe out the db, you're losing this
> xattr and so tests that are checking a combination of atributes
> and setting flags fail - specifically:
> /* test 11 - does having read only attribute still allow delete on close. */
> It'll probably also delete the NTACL xattrs also, so this isn't
> the right place to do it. Catching it at the POSIX open() call
> might be better instead. I know how to do this - let me fix
> it up and send you something back.

OK - try this. Passes base.delete for me. (deltest16a still
fails but that's a knownfail).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-smbd-vfs-Remove-any-stale-xattr-values-during-fil.patch
Type: text/x-diff
Size: 2245 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160720/ff9a182e/0001-s3-smbd-vfs-Remove-any-stale-xattr-values-during-fil.diff>

More information about the samba-technical mailing list