[PATCH] [WIP] Attempt to address flapping tests and file/directory mixups

[Andrew Bartlett]

I've been thinking about the flapping tests, and I think it might be
dev/inode re-use in vfs_xattr_tdb.

The fix should be simple: whenever we create a file, wipe the DB before
we return the file handle. 

I can't get the first attached test to pass samba3.base.delete for some
reason, and the second is really just a paper-over effort, so I
wondered if a smbd wizard could help me work out why this doesn't work?

Finally, if it is dev/inode re-use, that could be the reason we don't
see this as often away from sn-devel.

Thanks,

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vfs-Remove-any-stale-xattr-values-during-file-create.patch
Type: text/x-patch
Size: 2730 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160718/f1137b5f/0001-vfs-Remove-any-stale-xattr-values-during-file-create.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-smbd-Do-not-allow-FILE_ATTRIBUTE_DIRECTORY-on-non-di.patch
Type: text/x-patch
Size: 950 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160718/f1137b5f/0002-smbd-Do-not-allow-FILE_ATTRIBUTE_DIRECTORY-on-non-di.bin>