Tautological comparison in gcc 6.1.1
martin at meltin.net
Thu Jul 14 20:21:47 UTC 2016
On Thu, 14 Jul 2016 11:11:16 +0200, Michael Adam <obnox at samba.org>
> On 2016-07-14 at 18:45 +1000, Amitay Isaacs wrote:
> > On Thu, Jul 14, 2016 at 6:25 PM, Michael Adam <obnox at samba.org> wrote:
> > >
> > > Attached.
> > > It reverts the previous 3 patches and
> > > establishes the global no-error for taut.-comp.
> > >
> > > Tested with gcc 6 and gcc 4.8 this time.
> > >
> > > Cheers - Michael
> > >
> > Reviewed-by: Amitay Isaacs <amitay at gmail.com>
> > This is definitely a better option. You get the warnings, but does not
> > stop you from using --picky-developer.
> Umm, embarrassing: As Annop CS pointed out to me,
> I made a copy-and-paste error in my patch, to the
> effect of adding -Wno-error=deprecated-declarations
> again instead of -Wno-error=tautological-compare ...
> Secondly, I thought I tested with gcc6 but I only
> tested with gcc5.
> Finally, Amitay seems to have trusted my word that
> I tested with gcc6. ;-)
> The updated corrected patchset should finally fix it. :-D
I'm confused by the summary in the commit:
build: avoid -Wtautological-compare errors from gcc6+ by disabling it globally
The patch doesn't disable the warning, does it? I thought it only
stops it throwing errors?
I don't have a gcc6 handy to test on...
peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the samba-technical