Tautological comparison in gcc 6.1.1

[Jeremy Allison]

On Fri, Jul 15, 2016 at 06:26:56AM +1000, Martin Schwenke wrote:
> On Thu, 14 Jul 2016 11:33:05 +0200, Michael Adam <obnox at samba.org>
> wrote:
> 
> > On 2016-07-14 at 11:11 +0200, Michael Adam wrote:
> > > On 2016-07-14 at 18:45 +1000, Amitay Isaacs wrote:  
> > > > On Thu, Jul 14, 2016 at 6:25 PM, Michael Adam <obnox at samba.org> wrote:
> > > >   
> >  [...]  
> > > > 
> > > > Reviewed-by: Amitay Isaacs <amitay at gmail.com>
> > > > 
> > > > This is definitely a better option.  You get the warnings, but does not
> > > > stop you from using --picky-developer.  
> > > 
> > > Umm, embarrassing: As Annop CS pointed out to me,
> > > I made a copy-and-paste error in my patch, to the
> > > effect of adding -Wno-error=deprecated-declarations
> > > again instead of -Wno-error=tautological-compare ...
> > > 
> > > Secondly, I thought I tested with gcc6 but I only
> > > tested with gcc5.
> > > 
> > > Finally, Amitay seems to have trusted my word that
> > > I tested with gcc6. ;-)
> > > 
> > > The updated corrected patchset should finally fix it. :-D  
> > 
> > BTW: now *really* tested with gcc 6.1(f24), 5.3.1(f23),
> > 4.8.4(u144), and 4.4.3(u104).
> 
> Also tested on:
> 
> * gcc (Debian 5.4.0-6) 5.4.0 20160609
> 
>   From Debian testing
> 
> * gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-11)
> 
>   From RHEL 6.6 (unpatched)

OK, LGTM. Pushed (as I pushed the last broken version :-).