Tautological comparison in gcc 6.1.1

Michael Adam obnox at samba.org
Thu Jul 14 09:33:05 UTC 2016


On 2016-07-14 at 11:11 +0200, Michael Adam wrote:
> On 2016-07-14 at 18:45 +1000, Amitay Isaacs wrote:
> > On Thu, Jul 14, 2016 at 6:25 PM, Michael Adam <obnox at samba.org> wrote:
> > 
> > >
> > > Attached.
> > > It reverts the previous 3 patches and
> > > establishes the global no-error for taut.-comp.
> > >
> > > Tested with gcc 6 and gcc 4.8 this time.
> > >
> > > Cheers - Michael
> > >
> > 
> > Reviewed-by: Amitay Isaacs <amitay at gmail.com>
> > 
> > This is definitely a better option.  You get the warnings, but does not
> > stop you from using --picky-developer.
> 
> Umm, embarrassing: As Annop CS pointed out to me,
> I made a copy-and-paste error in my patch, to the
> effect of adding -Wno-error=deprecated-declarations
> again instead of -Wno-error=tautological-compare ...
> 
> Secondly, I thought I tested with gcc6 but I only
> tested with gcc5.
> 
> Finally, Amitay seems to have trusted my word that
> I tested with gcc6. ;-)
> 
> The updated corrected patchset should finally fix it. :-D

BTW: now *really* tested with gcc 6.1(f24), 5.3.1(f23),
4.8.4(u144), and 4.4.3(u104).

:-)

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/91906877/signature.sig>


More information about the samba-technical mailing list