[PATCH] shadow_copy2: Allow configurable prefix for snapshots

[Rajesh Joseph]

On Tue, Jul 12, 2016 at 7:56 PM, Michael Adam <obnox at samba.org> wrote:

> On 2016-07-08 at 12:55 +0200, Michael Adam wrote:
> > On 2016-06-28 at 21:01 +0530, Rajesh Joseph wrote:
> > > Hey guys,
> > >
> > > Sorry for this late update on this thread. Due to vacation and other
> > > priorities this left unattended.
> > >
> > > As Uri recommended I added test cases to cover shadow:format. Also
> > > addressed review comments from others.
> > >
> > > Please go through the patch and let me know if it looks OK or not.
> >
> > [...]
> >
> > So, these were my more superficial comments.
> > I will follow up with more detailed comments after
> > looking at the changes more.
>
> Update:
>
> Had a longer discussion with Rajesh.
> The overall logic looks good to me.
> Rajesh will follow up with an updated
> patchset for (final?) review.
>
> Cheers- Michael
>

I have split the patch into smaller ones and addressed Michael's comments.

Thanks & Regards,
Rajesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shadow_copy2-create-structure-to-store-module-specif.patch
Type: text/x-patch
Size: 8364 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0001-shadow_copy2-create-structure-to-store-module-specif-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-shadow_copy2-Fix-shadow_copy2_posix_gmt_string-retur.patch
Type: text/x-patch
Size: 2314 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0002-shadow_copy2-Fix-shadow_copy2_posix_gmt_string-retur-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-shadow_copy2-Add-test-cases-to-cover-shadow-format.patch
Type: text/x-patch
Size: 4330 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0003-shadow_copy2-Add-test-cases-to-cover-shadow-format-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-shadow_copy2-allow-configurable-prefix-for-snapshot-.patch
Type: text/x-patch
Size: 13531 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0004-shadow_copy2-allow-configurable-prefix-for-snapshot--0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-shadow_copy2-Add-test-case-for-snapprefix-and-delimi.patch
Type: text/x-patch
Size: 3281 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0005-shadow_copy2-Add-test-case-for-snapprefix-and-delimi-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-shadow_copy2-update-man-pages-for-the-newly-introduc.patch
Type: text/x-patch
Size: 1827 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/c8eefa68/0006-shadow_copy2-update-man-pages-for-the-newly-introduc-0001.bin>